Asynchronous threading phase2 #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factored its use that it only gets used inside of syscalls
…have no stack pointer
syrusakbary
reviewed
Apr 19, 2023
Co-authored-by: Syrus Akbary <[email protected]>
…asmer into asynchronous-threading-phase2
theduke
reviewed
May 15, 2023
There was a problem hiding this comment.
Why do we need that thread local?
If we really do need it, we can guard against bugs by storing some thread-relevant value in the thread local and panic on a mismatch.
(We can just store the whole WasiThread, since it's clone, and do Arc::ptr_eq for equality)
(rather than making the functions unsafe)
theduke
reviewed
May 15, 2023
There was a problem hiding this comment.
Why do we need that thread local?
If we really do need it, we can guard against bugs by storing some thread-relevant value in the thread local and panic on a mismatch.
(We can just store the whole WasiThread, since it's clone, and do Arc::ptr_eq for equality)
(rather than making the functions unsafe)
theduke
approved these changes
May 15, 2023
auto-merge was automatically disabled
May 15, 2023 18:06
Rebase failed
…asmer into asynchronous-threading-phase2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does a series of refactoring to prevent similar bugs to the one that was found in the asynchronous threading patch.
In particular:
inner()is scoped to the wasi module and no longer usable outsideinner()is marked asunsafeand any use of it is audited and wrapped with unsafeWasiEnvno longer copies theinner()